[ui-storageBrowser] Implement storage browser actions #3877
Conversation
nidhibhatg
force-pushed
the
nidhi_sb_actions_m
branch
from
269ae7f
to
c48188a
Compare
nidhibhatg
force-pushed
the
nidhi_sb_actions_m
branch
from
c48188a
to
04f2d2a
Compare
nidhibhatg
requested review from
bjornalm,
ramprasadagarwal,
JohanAhlen and
tabraiz12
| { | ||
| params: { | ||
| pagesize: '1000', | ||
| filter: searchTerm |
There was a problem hiding this comment.
I would apply the URI encoding here instead of when setting the state
| type: string; | ||
| } | ||
|
|
||
| const FileChooserModal = ({ |
There was a problem hiding this comment.
Like discussed on slack. The name is misleading if the only purpose is to let the user choose a destination path.
| return ( | ||
| <Modal | ||
| cancelText={cancelText} | ||
| className="hue-filechooser-modal cuix antd" |
There was a problem hiding this comment.
do you need the cuix antd classes here?
| ); | ||
|
|
||
| const getColumns = (file: FileChooserTableData) => { | ||
| const columns: ColumnProps<FileChooserTableData>[] = []; |
There was a problem hiding this comment.
Are we not duplicating a lot this behaviour from the StorageBrowserTable.tsx?
In my opinion the StorageBrowserTable.tsx should be more modular, e.g. the actual table in it should be reusable component. I would see if it was possible to create a reusable and configurable "FilesystemTable" that could be used by different components (like this one) instead of duplicating this code. We will also need an actual "file picker" (for the importer and other places) which also needs a "FilesystemTable" to display the files and folders.
What changes were proposed in this pull request?
How was this patch tested?
Please review Hue Contributing Guide before opening a pull request.