Add Import_cluster_template module #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rsuplina <[email protected]>
Signed-off-by: rsuplina <[email protected]>
wmudge
requested changes
Jan 24, 2024
|
|
||
| except FileNotFoundError: | ||
| self.cm_cluster_template_output = (f"Error: File '{self.template}' not found.") | ||
| self.file_not_found = True |
There was a problem hiding this comment.
Please call self.module.fail_json here rather than in line 180
|
|
||
| DOCUMENTATION = r""" | ||
| --- | ||
| module: cm_import_cluster_template |
There was a problem hiding this comment.
This should be simply cluster -- importing a cluster template is just one function of this module. The initial implementation can only include this functionality, but going forward, we should then add reconciliation and update logic. (This will be calls to PUT /clusters/{clusterName}.)
Signed-off-by: rsuplina <[email protected]>
Add pytest resources. Add unit tests for assemble_cluster_template module Signed-off-by: Webster Mudge <[email protected]>
…ge functions Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Short-circuit merger for initial fragment. Signed-off-by: Webster Mudge <[email protected]>
Add 'regex' alias. Update API docs. Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Relocate merge logic and update processing flow
Signed-off-by: rsuplina <[email protected]>
wmudge
approved these changes
Feb 29, 2024
| @@ -50,22 +50,29 @@ | |||
| type: bool | |||
| required: False | |||
| default: False | |||
| clusterName: | |||
| description: | |||
| - Name of Cloudera Manager Cluster | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.