Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CM Service Module #194

Merged
merged 5 commits into from
Jan 24, 2024
Merged

Add CM Service Module #194

merged 5 commits into from
Jan 24, 2024

Conversation

rsuplina
Copy link
Contributor

This commit contains:

  • cm_service.py module
  • Additonal function added to cm_utils.py
  • Pytest file for cm_service.py module

@rsuplina rsuplina requested a review from a team January 11, 2024 16:23
@wmudge wmudge added the enhancement New feature or request label Jan 16, 2024
@wmudge wmudge added this to the Release 4.3.1 milestone Jan 16, 2024
wmudge
wmudge requested changes Jan 16, 2024
View reviewed changes
plugins/module_utils/cm_utils.py Show resolved Hide resolved
plugins/modules/cm_service.py Outdated Show resolved Hide resolved
plugins/modules/cm_service.py Show resolved Hide resolved
plugins/modules/cm_service.py Show resolved Hide resolved
plugins/modules/cm_service.py Outdated Show resolved Hide resolved
@rsuplina
Add descirption
73a0917 
Signed-off-by: rsuplina <[email protected]>
wmudge
wmudge approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@wmudge wmudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open another PR / issue for updating the logic to handle check mode.

@wmudge wmudge merged commit 049fb36 into cloudera-labs:devel Jan 24, 2024
4 checks passed
@wmudge wmudge modified the milestones: Release 4.3.1, Release 4.4.0 May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmudge wmudge wmudge approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request validated
Milestone
Release 4.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rsuplina @wmudge