Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:change in count condition #13

Merged
merged 3 commits into from
Jul 26, 2024
Merged

fix:change in count condition #13

merged 3 commits into from
Jul 26, 2024

Conversation

Rupalgw
Copy link
Contributor

@Rupalgw Rupalgw commented Feb 23, 2024

what

• Test each module when the enable variable is true.
• Deploy the module, then set the enable variable to false, ensuring all resources are destroyed without errors.

why

  • the changes being made due to error in count condition

@Rupalgw Rupalgw added the enhancement New feature or request label Feb 23, 2024
@Rupalgw Rupalgw self-assigned this Feb 23, 2024
@@ -65,13 +65,13 @@ module "load-balancer" {

# Load Balancer
frontend_name = "mypublicIP"
frontend_private_ip_address_allocation = "Static"
frontend_private_ip_address_allocation = "static"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we are changing this?

frontend_private_ip_address = "10.0.1.6"
lb_sku = "Standard"

# Public IP
ip_count = 1
allocation_method = "Static"
allocation_method = "static"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we are changing this?

}

output "azurerm_public_ip_id" {
description = "the id for the azurerm_lb_public_ip resource"
value = azurerm_public_ip.default[*].id
value = azurerm_public_ip.default[0].id
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we are not using try in this? I think it will give error when we set enable variable false.

@d4kverma d4kverma merged commit 0a1bb8f into master Jul 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants