Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FullCalendar Resource #18

Merged
merged 24 commits into from
Feb 6, 2024
Merged

Update FullCalendar Resource #18

merged 24 commits into from
Feb 6, 2024

Conversation

jagmohansingh
Copy link
Member

@jagmohansingh jagmohansingh commented Oct 27, 2023

@jagmohansingh
Copy link
Member Author

@thepaulfox The changes are in packaging org. Can you please create a new package and test?

@jagmohansingh
Copy link
Member Author

jagmohansingh commented Jan 5, 2024

@thepaulfox The bundling on Marketing Calendar is complete and here is how it looks now:
Screenshot 2024-01-05 at 9 24 57 PM

This version uses webpack to bundle resources and have migrated to use the latest version of FullCalendar library.

All the code changes are in packaging org, please review.

cc @jsullivanlive

@thepaulfox
Copy link
Contributor

@jagmohansingh Why did you remove the list option? Was there an issue with it?

@jagmohansingh
Copy link
Member Author

@jagmohansingh Why did you remove the list option? Was there an issue with it?

@thepaulfox Just thought these are too many options 😄

@thepaulfox
Copy link
Contributor

@jagmohansingh I like the list option, I think it would be a good thing to be able to add to the release notes.

@thepaulfox
Copy link
Contributor

@jagmohansingh If you want to remove a view, day might not be that helpful since we don't show anything by the hour.

@jagmohansingh
Copy link
Member Author

jagmohansingh commented Jan 24, 2024

@thepaulfox I have removed the day option and added list option. Please review.

@thepaulfox
Copy link
Contributor

@jagmohansingh The list view doesn't have the same colors as the month and week view. The font is not white, and the powederBlue is not showing up as blue. The white font is especially important for the navy events and the dark red ones, but it looks like on the month view they all show up as white. Also, is PowederBlue spelled like that in the package? We should fix that spelling in the picklist, but support either spelling in the code for existing customers.
image

@jagmohansingh
Copy link
Member Author

@thepaulfox I have added fixes for text color. I can't update the static resource in packaging org until @jsullivanlive fixes the CA portal as I don't have password for that org.
Screenshot 2024-02-02 at 8 31 18 PM

Screenshot 2024-02-02 at 8 31 28 PM

@thepaulfox thepaulfox merged commit db13ccd into master Feb 6, 2024
2 checks passed
@thepaulfox thepaulfox deleted the gh-14 branch February 6, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants