Add HPA and PDB #202
Open
Add HPA and PDB #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
@apptiopzuo @daniel-spray |
|
@tiwarisanjay: Metrics agent doesn't support running more than one pod at this time. |
|
@apptiopzuo So how it supports high availability? One pod can easily go down if one zone is bad. |
You are right. We will need evaluate how to support the HA from the design. |
|
@apptiopzuo You can add redis in front. Check ArgoCD HA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding HorizontalPodAutoscaler and Disruption Budget for the Application
Where should the reviewer start?
https://github.com/cloudability/metrics-agent/tree/master/charts/metrics-agent
added :
- pdb.yaml
- hpa.yaml
update:
- values.yaml with pdb and hap. By default both are disabled with false value so no change and can be enabled with true value
How should this be manually tested?
Command to see the resources
Any background context you want to provide?
We are creating our own helm chart but would like to use the public one so adding all our new features to public helm charts for everyones benefits.
What picture best describes this PR (optional but encouraged)?
Adding HorizontalPodAutoscaler and Disruption Budget for the Application
What are the relevant Github Issues?
No issue
Developer Done List
For the Reviewer:
Just HPA and PDB's are added so no functionality change. Everything else will be same.
By approving this PR, the reviewer acknowledges that they have checked all items in this done list.
Reviewer/Approval Done List