Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

included add config and show config features #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

babarinde
Copy link

Hi @pst,
Add config and Show Config features added
One issue with implementing the remove config was, passing the variables seem to be a challenge.

In https://github.com/cloudControl/cctrl/blob/master/cctrl/app.py#L740 ,
args.variables expects to be an array (i think) as defined in
https://github.com/cloudControl/cctrl/blob/5fcdca83fc6fb26676b1ff3aa4f241663aa400de/cctrl/addonoptionhelpers.py#L69
getting an array of the keys to the delete http request is quite a challenge.
This is my first encounter with python so i guess my assumptions are quite right.
Cheers

@TooAngel
Copy link
Contributor

Thank you for the pull request. I think the added functionality is fine.
Changing the indentation from spaces to tabs, and leaving it in a mixed state is not so beneficial. If you can correct this, I'm happy to merge it.

@babarinde
Copy link
Author

Hi @TooAngel,
I sorry i haven't been able to do the formatting, however i also have a more pressing issue as regards the pull request now.
It seems the api.cloudcontrolled.com does not implement the resource that i speculated for adding config variables

/app/APP_NAME/deployment/DEPLOYMENT/config/

as when i try to add some config variables i get this error

no valid json: Gone Method 'POST' not allowed.

I also try changing the request to a PUT but i get the same error
Could it be that i am using the wrong resource?
Thanks and looking forward to your response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants