Skip to content

fix: use local lastSequence in ReadEvents to avoid state conflict #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use local lastSequence in ReadEvents to avoid state conflict #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ch05/ch05_05/transact.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ func (l *TransactionLogger) ReadEvents() (<-chan Event, <-chan error) {

go func() {
var e Event
var lastSeq uint64 = 0

defer close(outEvent)
defer close(outError)
Expand All @@ -133,7 +134,7 @@ func (l *TransactionLogger) ReadEvents() (<-chan Event, <-chan error) {
line, "%d\t%d\t%s\t%s",
&e.Sequence, &e.EventType, &e.Key, &e.Value)

if l.lastSequence >= e.Sequence {
if lastSeq >= e.Sequence {
outError <- fmt.Errorf("transaction numbers out of sequence")
return
}
Expand All @@ -145,7 +146,7 @@ func (l *TransactionLogger) ReadEvents() (<-chan Event, <-chan error) {
}

e.Value = uv
l.lastSequence = e.Sequence
lastSeq = e.Sequence

outEvent <- e
}
Expand Down