Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing meta-data-v2 extension #238

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Removing meta-data-v2 extension #238

merged 1 commit into from
Nov 22, 2024

Conversation

cweibel
Copy link
Contributor

@cweibel cweibel commented Nov 21, 2024

Changes proposed in this pull request:

security considerations

Continues the use of a token to access metadata information

@cweibel cweibel requested a review from a team as a code owner November 21, 2024 21:03
@@ -5,8 +5,8 @@ web_vm_type: production-concourse-web
worker_vm_type: production-concourse-worker
iaas_worker_vm_type: production-concourse-iaas-worker
web_vm_extensions: [production-concourse-lb]
worker_vm_extensions: [production-concourse-profile, meta-data-v2]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that the settings will still apply on Concourse VMs? I ask because these settings are the crux of making sure that BOSH builds take minutes rather than hours

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #235

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The setting is configured when the VM is created. To put it in place we either wait for a stemcell or recreate the vms (what I've been doing).

If we find that this is not working for some reason, the vm_extension configuration has a higher priority than the CPI configuration, I won't be removing the vm_extension from the cloud config until it is removed as a separate configuration in deployment manifests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the configuration at the CPI layer:

- type: replace
  path: /instance_groups/name=bosh/properties/aws/metadata_options?/http_tokens?
  value: required

- type: replace
  path: /instance_groups/name=bosh/properties/aws/metadata_options?/http_put_response_hop_limit?
  value: 2

They are the same two values set by #235 only now this is happening for ALL vms

@cweibel cweibel merged commit dcd8eb2 into main Nov 22, 2024
1 check passed
@cweibel cweibel deleted the remove-meta-data-v2 branch November 22, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants