Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing lidar polling config param #229

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Removing lidar polling config param #229

merged 1 commit into from
Jun 7, 2024

Conversation

ChrisMcGowan
Copy link
Contributor

Changes proposed in this pull request:

  • Removing the lidar_scanner_interval property - it was a blocker for specific use cases and not offering any platform wide benefit - this was a primary Pages usage blocker
  • By removing lidar_scanner_interval but keeping default_check_interval* resources in the config - we set default intervals for resource checks but allow specific resources to increase their interval using check_every in their resource definitions

security considerations

n/a

@ChrisMcGowan ChrisMcGowan requested a review from a team June 7, 2024 15:02
@ChrisMcGowan ChrisMcGowan merged commit 9fac7be into main Jun 7, 2024
1 check passed
@ChrisMcGowan ChrisMcGowan deleted the remove-lidar branch June 7, 2024 15:21
@ChrisMcGowan
Copy link
Contributor Author

FYI - a manual deploy was done earlier this week to remove this setting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants