Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added instructions for installation for Terraform 0.13. #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kovukono
Copy link

@kovukono kovukono commented Oct 9, 2020

Prerequisites

Put an x into the box(es) that apply:

  • This pull request fixes a bug.
  • This pull request adds a feature.
  • This pull request enhances existing functionality.
  • This pull request introduces breaking change.

Description

Updates install instructions for Terraform 0.13.

Issues Resolved

List any existing issues this pull request resolves.

Checklist

Put an x into all boxes that apply:

Tests

  • I have added tests to cover my changes.
  • All tests pass when I run make test.

Documentation

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Code Style

  • My code follows the code style of this project.
  • All checks pass when I run make checkfmt and make lint.

@khos2ow
Copy link
Contributor

khos2ow commented Oct 13, 2020

I don't think this would just work as is with Terraform v0.13.x as the provider needs to get rebuilt after go.mod was updated (basically this https://github.com/cloud-ca/terraform-provider-cloudca/blob/master/go.mod#L5)

@kovukono
Copy link
Author

I've been able to verify that the environment, vpc, network, ssh_key, public_ip, and instance of release 1.5.0 are currently working with Terraform 0.13.4. I could add the change to rebuild it for v1.6.0 if you'd prefer. Also, hi Khosrow!

@khos2ow
Copy link
Contributor

khos2ow commented Oct 14, 2020

Hi! 👋

Interesting, I didn't know that would even work without the upgrade! I think eventually it needs to get upgraded, but if it works as is maybe not very urgent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants