Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some logging to help trace #8

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

jtaleric
Copy link
Member

@jtaleric jtaleric commented Jan 15, 2024

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Adding trivial logger to the mix. Also removing the need for user/pass to be sent via config file, as we will pass that through the ES URL

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@jtaleric jtaleric force-pushed the adding-logging branch 3 times, most recently from 0274b8b to f8953b7 Compare January 15, 2024 20:54
Adding trivial logger to the mix. Also removing the need for user/pass
to be sent via config file, as we will pass that through the ES URL

Signed-off-by: Joe Talerico <[email protected]>
@shashank-boyapally
Copy link
Collaborator

Tested on local!! Logging is great!
LGTM
Merging!!

@shashank-boyapally shashank-boyapally merged commit d9451eb into cloud-bulldozer:main Jan 15, 2024
4 checks passed
@jtaleric jtaleric deleted the adding-logging branch January 15, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants