Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display OVN metrics from worker node #134

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

venkataanil
Copy link
Contributor

@venkataanil venkataanil commented Sep 10, 2024

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Prometheus query metric containerCPU-AggregatedWorkers is NOT
using the pod while fetching the data, so fixed that in the
worker panel.

ovnkube-master pod names is replaced with ovnkube-node pod from 4.14.

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@venkataanil
Copy link
Contributor Author

@rsevilla87
Copy link
Member

containerCPU-AggregatedWorkers

Note that the original query was something like:

uuid.keyword: $uuid AND metricName: "containerCPU" AND labels.pod.keyword: /ovnkube-master.*/

where metricName did't have the suffix .keyword, which is basically translated as a wildcard at the end of containerCPU*.
Other than that, that wasn't correct either, as the panels were adding up the per-pod values obtained from containerCPU-Masters, with the average value obtained from containerCPU-AggregatedWorkers, which is not correct at all.

TLTR; This change looks good to me , we just need to fix the issues you're observing with the panels first

Prometheus query metric containerCPU-AggregatedWorkers is NOT
using the pod while fetching the data, so fixed that in the
worker panel.

ovnkube-master pod names is replaced with ovnkube-node pod from 4.14.

Signed-off-by: venkataanil <[email protected]>
@venkataanil
Copy link
Contributor Author

I retained all old panels. I fixed the panel (i.e Aggregated OVNKube-node containers CPU) which was not worker earlier.
I have tested and got the panels rendered properly.

@rsevilla87 rsevilla87 self-requested a review September 24, 2024 13:21
Copy link
Member

@rsevilla87 rsevilla87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rsevilla87 rsevilla87 merged commit 3fc75cc into cloud-bulldozer:master Sep 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants