Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Public - UPerf Results dashboard to grafonnet. #109

Merged
merged 6 commits into from
Feb 9, 2024

Conversation

smanda99
Copy link
Collaborator

@smanda99 smanda99 commented Feb 6, 2024

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Adding Public - UPerf Results dashboard to grafonnet.

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@smanda99 smanda99 self-assigned this Feb 6, 2024
@smanda99 smanda99 requested a review from vishnuchalla February 7, 2024 02:36
@smanda99 smanda99 added the enhancement New feature or request label Feb 7, 2024
@vishnuchalla
Copy link
Collaborator

@vishnuchalla

old dashboard: http://dittybopper-dittybopper.apps.smanda-ocp1.perfscale.devcluster.openshift.com/d/noO0pWhSk/public-uperf-results?orgId=1

new dashboard: http://dittybopper-dittybopper.apps.smanda-ocp1.perfscale.devcluster.openshift.com/d/caF0pZ2Sk/public-uperf-results-dashboard?orgId=1&refresh=30s

Hosting these dashboards on your own cluster is not useful when they have elasticsearch as data source. Can you use your dev grafana instance instead to host them for testing and PR review purposes please?

@vishnuchalla
Copy link
Collaborator

old dashboard: https://grafana.rdu2.scalelab.redhat.com:3000/d/bca19562-2624-4102-bdd1-da7ac8561532/public-uperf-results-old?orgId=1

new dashboard: https://grafana.rdu2.scalelab.redhat.com:3000/d/b07cef83-826a-4f87-819b-0cd8529743ef/public-uperf-results-dashboard-new?orgId=1&refresh=30s

I just took a look at both the dashboards side by side, Values in UPerf Result Summary --> message_size column are completely irrelevant. Can you please cross check everything again and correct them?

@smanda99
Copy link
Collaborator Author

smanda99 commented Feb 9, 2024

image

here in the old dashboard the message_size is mentioned exact number. but in the new one it is rounding off to value and giving the B/s. 16384 is 16.4k (16400).

@vishnuchalla
Copy link
Collaborator

image

here in the old dashboard the message_size is mentioned exact number. but in the new one it is rounding off to value and giving the B/s. 16384 is 16.4k (16400).

Yes can you please correct that? Also message size in Kb/s doesn't make sense.

@smanda99
Copy link
Collaborator Author

smanda99 commented Feb 9, 2024

Copy link
Collaborator

@vishnuchalla vishnuchalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks :)

@vishnuchalla vishnuchalla merged commit 45abdfd into cloud-bulldozer:master Feb 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants