Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding additional metrics to track #79

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+44 −0
Open

Adding additional metrics to track #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions examples/trt-external-payload-cluster-density.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,28 @@ tests :
- "[Jira: kube-apiserver]"
direction: 1

- name: multusCPU
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should decide whether we want all metrics (including those not added here) to aggregate only the workload or also include the garbage collection metrics (lines 21-22 above).

metricName : containerCPU
labels.namespace.keyword: openshift-multus
metric_of_interest: value
agg:
value: cpu
agg_type: avg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This averages all pods and containers in the namespace .. do we want to focus on a container specifically? I think kube-rbac-proxy would be weighing it down

labels:
- "[Jira: multus]"
direction: 1

- name: monitoringCPU
metricName : containerCPU
labels.namespace.keyword: openshift-monitoring
metric_of_interest: value
agg:
value: cpu
agg_type: avg
labels:
- "[Jira: monitoring]"
direction: 1

- name: ovnCPU
metricName : containerCPU
labels.namespace.keyword: openshift-ovn-kubernetes
Expand Down
22 changes: 22 additions & 0 deletions examples/trt-payload-cluster-density.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,28 @@ tests :
- "[Jira: kube-apiserver]"
direction: 1

- name: multusCPU
metricName : containerCPU
labels.namespace.keyword: openshift-multus
metric_of_interest: value
agg:
value: cpu
agg_type: avg
labels:
- "[Jira: multus]"
direction: 1

- name: monitoringCPU
metricName : containerCPU
labels.namespace.keyword: openshift-monitoring
metric_of_interest: value
agg:
value: cpu
agg_type: avg
labels:
- "[Jira: monitoring]"
direction: 1

- name: ovnCPU
metricName : containerCPU
labels.namespace.keyword: openshift-ovn-kubernetes
Expand Down
Loading