Max lookback #65
Merged
Max lookback #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shashank Reddy Boyapally <[email protected]>
Signed-off-by: Shashank Reddy Boyapally <[email protected]>
Signed-off-by: Shashank Reddy Boyapally <[email protected]>
|
After the pre-requisite PR is merged, can you update this one by adding few usage examples with loopback period vs size? |
Signed-off-by: Shashank Reddy Boyapally <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Added to lookback for n number of runs. Do not merge unit fmatch 0.0.9 and #57 is merged
Context
This particular feature clashes along with the idea of having to lookback for X number of days. The precedence of both the flags are equal and the it returns the runs until the cutoff whichever is shorter. To provide precedency one can understand the following example:
Consider the following runs
Today is 27 Aug, and
case 1: we want to get data of previous 5 days, the
--lookbackflag gets us the runs [2,9]case 2: we want to get data of previous 6 runs, the
--lookback-sizeflag gets us the runs [4,9]case 3: when we use both
--lookbackand--lookback-size--lookback 5d --lookback-size 6now this gets the union of both [2,9] and [4,9] which is [4,9]--lookback 3d --lookback-size 6now this gets the union of both [7,9] and [4,9] which is [7,9]This is similar to how car manufacturers warranty plays out such as 5years of 60k miles.
Why we do not want higher precedence for a single flag?
Related Tickets & Documents
Checklist before requesting a review
Testing