Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting build urls for when uuid and baseline are set #32

Merged
merged 1 commit into from
May 20, 2024
Merged

Getting build urls for when uuid and baseline are set #32

merged 1 commit into from
May 20, 2024

Conversation

paigerube14
Copy link
Collaborator

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

With the changes from #15, when using the uuid and baseline parameters I had added, it was now throwing an error trying to find the buildUrl for each uuid. This will get that data without erroring

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.
    $orion --uuid $UUID --baseline $BASELINE_UUID --config examples/small-scale-node-density-cni.yaml --debug
,uuid,timestamp,P99,apiserverCPU_cpu_avg,ovnCPU_cpu_avg,etcdCPU_cpu_avg,etcdDisk_duration_avg,buildUrl
0,26feeb47-3f7d-45b4-9926-f8f774a08385,2023-12-14T23:13:52.563810987Z,2000,22.754171747822074,3.4660279278374864,21.24262421293023,0.010324644209403131,https://tinyurl.com/26843gjw
1,0f731581-6630-4620-921f-3d9fa11d1330,2024-05-07T21:20:02.737893524Z,2000,19.23959183682067,3.21447647319984,16.56003964168054,0.009221293420220414,https://tinyurl.com/266dh3ay

@paigerube14 paigerube14 force-pushed the build_urls_uuid branch 3 times, most recently from d3da1dc to a3401de Compare May 10, 2024 18:39
vishnuchalla
vishnuchalla approved these changes May 12, 2024
View reviewed changes
Copy link
Collaborator

@vishnuchalla vishnuchalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vishnuchalla vishnuchalla mentioned this pull request May 12, 2024
Closed
7 tasks
@paigerube14
Getting build urls for when uuid and baseline are set
29cfe50 
rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED

Signed-off-by: Paige Rubendall <[email protected]>
jtaleric
jtaleric approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@jtaleric jtaleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shashank-boyapally
Copy link
Contributor

/lgtm

@jtaleric jtaleric merged commit 4546fd6 into cloud-bulldozer:main May 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtaleric jtaleric jtaleric approved these changes

@vishnuchalla vishnuchalla vishnuchalla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paigerube14 @shashank-boyapally @jtaleric @vishnuchalla