Skip to content

Commit

Permalink
acking the 4.18 and 4.19 issues
Browse files Browse the repository at this point in the history
Acking the current issues we have identified in 4.18 and 4.19.

Signed-off-by: Joe Talerico aka rook <[email protected]>
  • Loading branch information
jtaleric committed Dec 17, 2024
1 parent bdf773e commit 53585bc
Show file tree
Hide file tree
Showing 7 changed files with 19 additions and 1 deletion.
5 changes: 5 additions & 0 deletions ack/4.18_cluster-density_ack.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
ack:
- uuid: 7f7337aa-cee3-4a36-b154-a7c48ed1fb75
metric: etcdCPU_avg
reason: "Below 10%"
1 change: 1 addition & 0 deletions ack/4.18_crd-scale_ack.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
---
5 changes: 5 additions & 0 deletions ack/4.18_node-density_ack.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
ack:
- uuid: 7f7337aa-cee3-4a36-b154-a7c48ed1fb75
metric: etcdCPU_avg
reason: "Below 10%"
5 changes: 5 additions & 0 deletions ack/4.19_cluster-density_ack.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
ack :
- uuid: cfae6e1e-8c47-4628-be52-8705c8c64285
metric: kubelet_avg
reason: "kube-burner change which increased cpu for kubelet, it was reverted."
1 change: 1 addition & 0 deletions ack/4.19_crd-scale_ack .yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
---
1 change: 1 addition & 0 deletions ack/4.19_node-density_ack.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
---
2 changes: 1 addition & 1 deletion pkg/algorithms/edivisive/edivisive.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def _analyze(self):

# Process if we have ack'ed regression
ackSet = set()
if len(self.options["ack"]) > 1 :
if len(self.options["ack"]) > 1 and self.options["ackMap"] is not None:
for ack in self.options["ackMap"]["ack"]:
pos = series.find_by_attribute("uuid",ack["uuid"])
ackSet.add(str(pos[0]) + "_" + ack["metric"])
Expand Down

0 comments on commit 53585bc

Please sign in to comment.