Initial draft for client-go abstraction (Reusable Components) #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishnuchalla
changed the title
Codecov Report
@@ Coverage Diff @@
## main #32 +/- ##
=======================================
Coverage 85.13% 85.13%
=======================================
Files 6 6
Lines 343 343
=======================================
Hits 292 292
Misses 37 37
Partials 14 14 |
vishnuchalla
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR follows a Repository Design Pattern to implement reusable components for resources that we use on our cluster while we run workloads.
This is a Draft PR but has
DeploymentComponent Working. Please feel free to simply run theexample/deployment/main.gofile to see its different types of usage and working in action. Once this approach is approved will move forward with actual PRs of each component at a time.Related Tickets & Documents
Checklist before requesting a review
Testing
Tested on self managed AWS cluster using the
example/deployment/main.gofile. Can use the same to reproduce the testing and to play-around.