Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the Python files for consistent formatting #139

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Refactor the Python files for consistent formatting #139

merged 1 commit into from
Dec 5, 2024

Conversation

MVarshini
Copy link
Collaborator

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Formatted all the .py files under backend folder as it improves the readability.

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@MVarshini MVarshini self-assigned this Dec 4, 2024
@MVarshini MVarshini mentioned this pull request Dec 4, 2024
Open
7 tasks
dbutenhof
dbutenhof approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where I really wish we had a test system in place; but black shouldn't break anything, and I haven't seen anything that looks bad. The improved code style consistency will be valuable going forward: thanks!

@dbutenhof dbutenhof mentioned this pull request Dec 4, 2024
Merged
7 tasks
jaredoconnell
jaredoconnell approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it was formatted correctly.

@dbutenhof dbutenhof merged commit c17e5db into cloud-bulldozer:revamp Dec 5, 2024
1 check passed
@dbutenhof dbutenhof mentioned this pull request Dec 6, 2024
Draft
7 tasks
dbutenhof added a commit to dbutenhof/cpt-dashboard that referenced this pull request Dec 6, 2024
@dbutenhof
Add a simple unit test framework.
40887bd 
This uses `black`, `isort` and `flake8` to check code quality, although
failure is ignored until we've cleaned it up (which has begin in
PR cloud-bulldozer#139 against the `revamp` branch).

Minimal unit testing is introduced, generating a code coverage report.
The text summary is added to the Action summary page, and the more
detailed HTML report is stored as an artifact for download.

NOTE: The GitHub Action environment is unhappy with `uvicorn` 0.15;
upgrading to the latest 0.32.x seems to work and hasn't obviously
broken anything else.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbutenhof dbutenhof dbutenhof approved these changes

@jaredoconnell jaredoconnell jaredoconnell approved these changes

Assignees

@MVarshini MVarshini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MVarshini @jaredoconnell @dbutenhof