Added the running rosa spots ability #349
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@krishvoor ptal. 👋 |
athiruma
force-pushed
the
add-rosa-spot-ability
branch
from
c4bdeba to
0279cb3
Compare
krishvoor
reviewed
Aug 12, 2023
| if [ "$SPOT_POOL_READY" == "true" ]; then | ||
| # Node count is number of workers pool + 3 infra | ||
| NODES_COUNT=$(($2+3)) | ||
| else |
There was a problem hiding this comment.
Which condition needs NODE_COUNT=$2
There was a problem hiding this comment.
Before spot_pool_ready, I need to check whether the SPOT nodes are ready or not. So, NODES_COUNT =$2 represent the number passing to the wait_for_nodes_ready
| if [ "$SPOT_POOL_READY" == "true" ]; then | ||
| _wait_for_nodes_ready $1 ${COMPUTE_WORKERS_NUMBER} "node-role.kubernetes.io/worker" | ||
| else | ||
| DEFAULT_WORKER_NODES=3 |
There was a problem hiding this comment.
Shouldn't the default be always openshift_worker_count?
There was a problem hiding this comment.
openshift_worker_count=9
The workflow will be,
default cluster= 3(M+W-I)
We already added 3 nodes, the remaining 6 nodes would be SPOT nodes.
So I added the DEFAULT_WORKER_NODES=3 to verify that 3 nodes in ready state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Span the Rosa worker nodes with the help of machinepools by creating the default cluster with 3(M+W+I).
The remaining Spot worker nodes are WorkerNodes - 3
Related Tickets & Documents
Checklist before requesting a review
Testing
Ran the airflow cluster by creating a playground on the sailplane cluster.