Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing of install task variables to downstream tasks of a dag #218

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Harshith-umesh
Copy link
Member

Description

This fix makes it possible to pass variables generated in the install task namely the cluster name and UUID of the install task for rosa and rogcp dags. The passed variables can be accessed by any of the following tasks(benchmarks,cleanup etc) in the dag.
A limitation of the bash operator is that only a single string can be passed from a task(script), so a concatenation of the above 2 vars, separated by '@' delimiter is passed, the receiving tasks have to separate the 2 from the pulled string.
Dag run eg: dag link
The passed string is accessible to the benchmark scripts and the cleanup script.

Fixes

https://issues.redhat.com/browse/PERFSCALE-1520

@Harshith-umesh Harshith-umesh requested review from morenod and dry923 June 27, 2022 13:01
Copy link
Collaborator

@morenod morenod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #218 (c9449c3) into master (1b34f37) will decrease coverage by 0.07%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
- Coverage   93.32%   93.24%   -0.08%     
==========================================
  Files          24       24              
  Lines        1003     1007       +4     
==========================================
+ Hits          936      939       +3     
- Misses         67       68       +1     
Flag Coverage Δ
gha 93.24% <75.00%> (-0.08%) ⬇️
python-3.9 93.24% <75.00%> (-0.08%) ⬇️
unit 93.24% <75.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...penshift_nightlies/tasks/utils/final_dag_status.py 47.05% <0.00%> (-2.95%) ⬇️
dags/openshift_nightlies/tasks/benchmarks/e2e.py 92.75% <100.00%> (ø)
...s/openshift_nightlies/tasks/install/rogcp/rogcp.py 100.00% <100.00%> (ø)
...ags/openshift_nightlies/tasks/install/rosa/rosa.py 100.00% <100.00%> (ø)
...t_nightlies/tasks/install/hypershift/hypershift.py 100.00% <0.00%> (ø)
dags/openshift_nightlies/models/release.py 97.67% <0.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b34f37...c9449c3. Read the comment docs.

@Harshith-umesh Harshith-umesh requested a review from mukrishn June 28, 2022 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants