JsChecker: support extensionless ES6 imports #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'm not ready to accept PRs here. Could we add a test in the meantime? |
|
@robfig I'm mostly ready to accept PRs 🎉. If you could add a testcase, we can merge this. |
|
Cross post: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cross post from bazelbuild#409
I'm not sure if this is the best way to accomplish it, but it's working for us and I didn't see an obvious alternative. We now have some hundreds of files using workspace-relative absolute extensionless ES6 imports and it all works fine with rules_closure & jsx.