-
-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discover nbb through nrepl describe #3466 #3467
Discover nbb through nrepl describe #3466 #3467
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks much for responding so quickly!
A couple suggestions. Also, please also include a Changelog entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Please make sure to make the linter pass.
Co-authored-by: vemv <[email protected]>
…cider into fix/jvm-connect-perf-3466
Thanks much! I've cherry-picked this, preserving attribution. |
See issue.
The main idea for the dynamic discovery of the nrepl server capabilities was that you start out with a blank repl
and it augments itself by discovering the server.
The eval during startup was a hit of 1.6 seconds on my machine and 2 for vemv.
So the current change is to rely on the nrepl descibe op.
Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
eldev test
)eldev lint
) which is based onelisp-lint
and includescheckdoc
, check-declare, packaging metadata, indentation, and trailing whitespace checks.