Cancel release artifact workflow on interruption - #5647
Closed
clockwork-labs-bot wants to merge 1 commit into
Closed
Cancel release artifact workflow on interruption#5647clockwork-labs-bot wants to merge 1 commit into
clockwork-labs-bot wants to merge 1 commit into
Conversation
clockwork-labs-bot
requested review from
bfops,
cloutiertyler,
jdetter and
rekhoff
as code owners
August 2, 2026 12:24
Collaborator
|
meh. attach-artifacts is valid one way or another |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Cancel the
attach-artifacts.ymlworkflow run whencargo-release release github-releaseis interrupted while waiting for it.The public
Internal Testsworkflow already cancels the private workflow it dispatches when the wrapper is canceled. This applies the same behavior to the release helper path that dispatches and waits forattach-artifacts.yml.If the release helper receives
SIGINTorSIGTERMwhilegh run watchis waiting, it now runsgh run cancel <run-id>for the dispatched workflow before exiting.I audited SpacetimeDBPrivate and did not find another job/tool path that both dispatches and waits on a long-running workflow, so this PR only changes SpacetimeDB.
API and ABI breaking changes
None.
Expected complexity level and risk
attach-artifacts.ymlhas been dispatched and while the helper is waiting on that specific run id.Testing
PATH=/Users/clockworklabs/.rustup/toolchains/1.93.0-aarch64-apple-darwin/bin:$PATH /Users/clockworklabs/.rustup/toolchains/1.93.0-aarch64-apple-darwin/bin/cargo check -p spacetimedb-release/Users/clockworklabs/.rustup/toolchains/1.93.0-aarch64-apple-darwin/bin/rustfmt --edition 2024 --check tools/release/src/targets/github_release.rsgit diff --check