Add C# client SDK procedures #3666
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
reviewed
Nov 19, 2025
Comment on lines
+839
to
+853
| let mut func_params: String = String::new(); | ||
| let mut func_args: String = String::new(); | ||
|
|
||
| for (arg_i, (arg_name, arg_ty)) in procedure.params_for_generate.into_iter().enumerate() { | ||
| if arg_i != 0 { | ||
| func_params.push_str(", "); | ||
| func_args.push_str(", "); | ||
| } | ||
|
|
||
| let arg_type_str = ty_fmt_with_ns(module, arg_ty, self.namespace); | ||
| let arg_name = arg_name.deref().to_case(Case::Camel); | ||
|
|
||
| write!(func_params, "{arg_type_str} {arg_name}").unwrap(); | ||
| write!(func_args, "{arg_name}").unwrap(); | ||
| } |
Contributor
There was a problem hiding this comment.
could be deduped with reducers?
| }) | ||
| } | ||
|
|
||
| fn ty_fmt_with_ns<'a>(module: &'a ModuleDef, ty: &'a AlgebraicTypeUse, namespace: &'a str) -> impl fmt::Display + 'a { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Closes: #3533
Updated the C# SDK to handle procedures and procedure callbacks in a similar fashion to the Rust client as well as added the codegen to support it.
API and ABI breaking changes
N/A
Expected complexity level and risk
2 - This adds a new testing frame that should be removed once procedures are handled with C# module bindings
Testing
Added /sdks/csharp/examples~/regression-tests/procedure-client to match modules/sdk-test-procedure which we can roll into the standard regression-tests once C# supports the procedure attribute.