Add ProcedureContext::with_tx
#3638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
force-pushed
the
centril/proc-with-transaction
branch
2 times, most recently
from
fcaf181 to
ef30e09
Compare
Centril
changed the title
ProcedureContext::with_transactionProcedureContext::with_tx
gefjon
reviewed
Nov 13, 2025
Contributor
gefjon
left a comment
gefjon
left a comment
There was a problem hiding this comment.
- See comment in
ModuleSubscriptions::send_procedure_message: I think (but am not confident) that we need to pass the procedure's last-referenced TX offset through and delay the procedure message in the case where the client is subscribed to confirmed reads. If I'm wrong about that because the queue is ordered anyways, you should instead update the comment with my reasoning. But I don't think that's right - if the client is not subscribed to the TX's writes, or if the TX was aborted rather than committed, we still should delay the procedure result message. In the rolled-back TX case we should include the most recent committed TX at the time of the rollback, I think. - I would greatly appreciate a test case added to the
sdk-test-proceduremodule andsdks/rust/tests/procedure-clientwhich exercises this functionality, including observing rows inserted within the TX.
gefjon
reviewed
Nov 17, 2025
Centril
force-pushed
the
centril/proc-with-transaction
branch
4 times, most recently
from
bef087f to
8da6dbe
Compare
gefjon
approved these changes
Nov 19, 2025
Contributor
gefjon
left a comment
gefjon
left a comment
There was a problem hiding this comment.
This looks great, thanks! Minor nits which I'll trust you to handle appropriately.
Centril
force-pushed
the
centril/proc-with-transaction
branch
from
649057b to
fedede8
Compare
Centril
force-pushed
the
centril/proc-with-transaction
branch
from
fedede8 to
b769e58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds
ProcedureContext::{with_tx, try_with_tx}.Fixes #3515.
API and ABI breaking changes
None
Expected complexity level and risk
2
Testing
An integration test
test_calling_with_txis added.