Add system table for tracking view subscribers #3482
Merged
+146
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-spacetime
force-pushed
the
joshua/system-table-for-read-sets
branch
from
05ba068 to
69afdbb
Compare
joshua-spacetime
force-pushed
the
joshua/system-table-for-read-sets
branch
from
d2e15e5 to
ea319e5
Compare
joshua-spacetime
changed the title
Shubham8287
reviewed
Oct 30, 2025
Shubham8287
reviewed
Oct 30, 2025
Shubham8287
reviewed
Oct 30, 2025
Co-authored-by: Shubham Mishra <[email protected]> Signed-off-by: joshua-spacetime <[email protected]>
Shubham8287
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds two new system tables for views. One tracks view arguments, the other tracks view subscribers.
st_view_arggenerates a unique id for each unique argument instantiation. This id will act as a foreign key that both read sets and backing tables can reference.st_view_clientis needed so that we can drop views when clients unsubscribe or disconnect. Note this disconnect logic is not implemented in this patch.Eventually both of these tables should be ephemeral. There's no reason they need to write to the commitlog.
Note also that the schema of a view's backing table has been updated. It no longer stores a view's argument values but rather the
idfromst_view_arg.API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
Tests will be added in the patch that computes read sets