Skip to content

Conversation

bfops
Copy link
Collaborator

@bfops bfops commented Oct 2, 2025

Description of Changes

It turns out that multi-line run statements don't fail properly on Windows. If one of the lines fails, the run won't exit early, and in fact the step will return successful.

API and ABI breaking changes

CI-only changes.

Expected complexity level and risk

1

Testing

@bfops bfops changed the title Fail properly on Windows CI CI - Multi-line runs fail properly on Windows Oct 2, 2025
@bfops bfops requested a review from jdetter October 2, 2025 20:26
@bfops bfops marked this pull request as ready for review October 2, 2025 20:30
Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for investigating this Zeke 👍

@bfops bfops added this pull request to the merge queue Oct 3, 2025
Merged via the queue into master with commit f478e11 Oct 3, 2025
26 of 27 checks passed
@bfops bfops deleted the bfops/ci-windows-fail branch October 3, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants