Skip to content

Conversation

kim
Copy link
Contributor

@kim kim commented Sep 24, 2025

Allows the SpacetimeDBClient to be configured with or without confirmed reads. Like for TypeScript, the parameter is optional -- the server chooses the default if not set explicitly.

Expected complexity level and risk

1

Testing

I don't actually know what I'm doing 😅

Allows the SpacetimeDBClient to be configured with or without confirmed
reads. Like for [TypeScript], the parameter is optional -- the server
chooses the default if not set explicitly.

[TypeScript]: #3247
@kim kim requested a review from rekhoff September 24, 2025 12:12
kim added a commit that referenced this pull request Sep 24, 2025
For consistency with [TypeScript] and [C#].
If `DbConnectionBuilder::with_confirmed_reads` is not called, don't set
the parameter on the connection URL, so that the server can choose the
default.

[TypeScript]: #3247
[C#]: #3282
github-merge-queue bot pushed a commit that referenced this pull request Sep 24, 2025
For consistency with [TypeScript] and [C#].

If `DbConnectionBuilder::with_confirmed_reads` is not called, don't set
the parameter on the connection URL, so that the server can choose the
default.

[TypeScript]: #3247
[C#]: #3282

# Expected complexity level and risk

1
@bfops bfops added the release-any To be landed in any release window label Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-any To be landed in any release window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants