Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log failure to start service (e.g., port already in use) #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zackse
Copy link

@zackse zackse commented Apr 19, 2019

Previously, failure to bind would result in a silent failure after the "Listening on " message. This change wraps the call to ListenAndServe to report any failure.

# ./aws-signing-proxy -target https://my-endpoint.amazonaws.com -port 9999 &
[3] 26203
Listening on :9999

# ./aws-signing-proxy -target https://my-endpoint.amazonaws.com -port 9999
Listening on :9999
2019/04/19 11:51:43 listen tcp :9999: bind: address already in use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant