-
Notifications
You must be signed in to change notification settings - Fork 27
rails 8 support #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rails 8 support #77
Conversation
Hey @sebyx07 did you try this on a Rails 8 stack in a production context ? |
yeah |
Thanks. I'll use it and report if I see any issue on my side. |
In case anyone needs a feedback : Seems to run perfectly in production since about a month. |
Hey @samsarkleio we love this gem over at getwalter.com (half of us are former Clions! Ainsley Robertson, Jordan Raine, Joe Krump and Ying Ying Choi) would love to see you guys merge this to unblock the rails 8 upgrade! Thanks for sharing Jit preloader with the world |
@clio/application-security Could we get the second review here and merge this in? |
As this new version also changes the minimum supported version of Rails the Readme should be updated to let users know what version of this gem they need depending on what version of Rails they have. Or, a note that mentions the minimum supported version of Rails |
cleaned up |
Interesting, I've never seen version specific Gemfile.lock files before. I think I would need to be walked through this a little to better understand what is happening here in order to give a proper review. |
spec.homepage = "https://github.com/clio/jit_preloader" | ||
spec.metadata["homepage_uri"] = spec.homepage | ||
spec.metadata["source_code_uri"] = spec.homepage | ||
spec.email = ['[email protected]'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick... not sure these needed to change 🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, ya, now it alternates between single and double quotes. :P
@@ -1,3 +1,3 @@ | |||
module JitPreloader | |||
VERSION = "3.1.0" | |||
VERSION = "8.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason we're jumping versions from 3 -> 8 for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to keep it in sync with rails, because this gem patches ar. it's simpler to then update it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small comments, looks fine otherwise. Can we include a PR description, even if its just re-iterating that we're upgrading to rails 8 and requiring the minimum version.
@jnraine 👋
@ryansdwilson just self host the gem meanwhile, depending on others suck. this is what i do https://github.com/geminabox/geminabox |
@sebyx07, looks like we are good to merge this one. |
@@ -1,2 +1,3 @@ | |||
require "bundler/gem_tasks" | |||
# frozen_string_literal: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is enabled by default in Ruby 3.4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the ' vs " mixing and the redundant # frozen_string_literal: true
, looks good.
Thank you Clio squad! Appreciate your work on this. |
Rails 8 Support
This PR adds support for Rails 8 while maintaining backward compatibility with Rails 7.1+.
🚀 Motivation
With Rails 8.0 now released, this gem needs to support the latest Rails version to enable users to upgrade their applications. Several users have requested this update to unblock their Rails 8 migrations.
📋 Changes Made
Version & Dependencies:
3.1.0
→8.0.0
(aligned with Rails major version for easier tracking)'>= 7.1', '< 9'
(supports Rails 7.1, 7.2, and 8.0+)CI & Testing:
Gemfile.7.1
for backward compatibility testing🧪 Testing
Migration path for older Rails versions:
jit_preloader
v3.1.0jit_preloader
v8.0.0+