Skip to content

Commit

Permalink
Merge branch 'release/0.1.17' into main
Browse files Browse the repository at this point in the history
  • Loading branch information
erikvw committed Sep 10, 2024
2 parents 4348c97 + 47ab9c5 commit 1dc2900
Show file tree
Hide file tree
Showing 7 changed files with 24 additions and 16 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,9 @@ jobs:
fail-fast: false
matrix:
python-version: ['3.12']
django-version: ['4.2', '5.0', '5.1', 'dev']
django-version: ['4.2', '5.1', 'dev']
database-engine: ["mysql", "postgres"]

services:
mysql:
image: mysql:latest
Expand Down Expand Up @@ -68,7 +69,6 @@ jobs:
python -m pip install --upgrade pip
python -m pip install -r https://raw.githubusercontent.com/clinicedc/edc/develop/requirements.tests/tox.txt
- name: Tox tests
run: |
tox -v
Expand Down
13 changes: 7 additions & 6 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ repos:
- "-x *test*.py"

- repo: https://github.com/psf/black
rev: 24.4.2
rev: 24.8.0
hooks:
- id: black
language_version: python3.12

- repo: https://github.com/pycqa/flake8
rev: 7.1.0
rev: 7.1.1
hooks:
- id: flake8
args:
Expand All @@ -30,16 +30,17 @@ repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.6.0
hooks:
- id: requirements-txt-fixer
files: requirements/.*\.txt$
- id: trailing-whitespace
- id: check-added-large-files
- id: fix-byte-order-marker
- id: check-docstring-first
- id: check-executables-have-shebangs
- id: check-merge-conflict
- id: check-toml
- id: debug-statements
- id: detect-private-key
- id: fix-byte-order-marker
- id: requirements-txt-fixer
files: requirements/.*\.txt$
- id: trailing-whitespace

- repo: https://github.com/adrienverge/yamllint
rev: v1.35.1
Expand Down
5 changes: 3 additions & 2 deletions edc_qareports/sql_generator/requisition_subquery.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,9 @@ class RequisitionSubquery(CrfSubquery):
template: str = field(
init=False,
default=Template(
"select req.subject_identifier, req.id as original_id, req.subject_visit_id, "
"req.report_datetime, req.site_id, v.visit_code, v.visit_code_sequence, "
"select req.subject_identifier, req.id as original_id, " # nosec B608
"req.subject_visit_id, req.report_datetime, req.site_id, v.visit_code, "
"v.visit_code_sequence, "
"v.schedule_name, req.modified, '${label_lower}' as label_lower, "
"'${label}' as label, count(*) as records "
"from ${subjectrequisition_dbtable} as req "
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<a title="{{ label|default:"Change CRF"}}" role="button" class="button" href="{{ url }}">Change&nbsp;CRF</a>
<a title="{{ title|default:"Change CRF"}}" role="button" class="button" href="{{ url }}">{{ label|default:"Change&nbsp;CRF" }}</a>
7 changes: 7 additions & 0 deletions edc_qareports/tests/test_settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
"edc_navbar.E002",
"edc_navbar.E003",
"edc_consent.E001",
"edc_sites.E001",
"edc_sites.E002",
],
EDC_AUTH_SKIP_AUTH_UPDATER=True,
EDC_SITES_REGISTER_DEFAULT=False,
Expand All @@ -33,6 +35,8 @@
"django_db_views",
"edc_auth.apps.AppConfig",
"edc_action_item.apps.AppConfig",
"edc_adverse_event.apps.AppConfig",
"adverse_event_app.apps.AppConfig",
"edc_appointment.apps.AppConfig",
"edc_device.apps.AppConfig",
"edc_timepoint.apps.AppConfig",
Expand All @@ -46,6 +50,9 @@
"edc_sites.apps.AppConfig",
"edc_visit_schedule.apps.AppConfig",
"edc_visit_tracking.apps.AppConfig",
"edc_dashboard.apps.AppConfig",
"edc_subject_dashboard.apps.AppConfig",
"edc_review_dashboard.apps.AppConfig",
"edc_qareports.apps.AppConfig",
"edc_appointment_app.apps.AppConfig",
"edc_appconfig.apps.AppConfig",
Expand Down
8 changes: 4 additions & 4 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ exclude_lines = [
legacy_tox_ini = """
[tox]
envlist =
py{312}-dj{42,50,dev},
py{312}-dj{42,51,dev},
lint
isolated_build = true
Expand All @@ -47,7 +47,7 @@ python =
[gh-actions:env]
DJANGO =
4.2: dj42
5.0: dj50
5.1: dj51
dev: djdev, lint
[testenv]
Expand All @@ -57,11 +57,11 @@ deps =
-r https://raw.githubusercontent.com/clinicedc/edc/develop/requirements.tests/edc.txt
-r https://raw.githubusercontent.com/clinicedc/edc/develop/requirements.tests/third_party_dev.txt
dj42: Django>=4.2,<5.0
dj50: Django>=5.0
dj51: Django>=5.1,<5.2
djdev: https://github.com/django/django/tarball/main
commands =
pip install -U pip coverage[toml]
pip install -U pip
pip --version
pip freeze
coverage run -a runtests.py
Expand Down
1 change: 0 additions & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ classifiers=
Programming Language :: Python :: 3.12
License :: OSI Approved :: GNU General Public License v3 (GPLv3)


[options]
python_requires = >=3.12
zip_safe = False
Expand Down

0 comments on commit 1dc2900

Please sign in to comment.