Skip to content

fix(clerk-js): Allow only members with manage billing permission to manage billing in OP #5835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

octoper
Copy link
Member

@octoper octoper commented May 5, 2025

Description

Member without any billing permissions

Organization Profile

CleanShot 2025-05-05 at 21 23 27@2x

Pricing table

CleanShot 2025-05-05 at 21 24 39@2x

Member with only org:sys_billing:read

Organization Profile with a subscription

CleanShot 2025-05-05 at 21 25 15@2x

Organization Profile without active paid plan

CleanShot 2025-05-05 at 21 25 54@2x

Available plans screen

CleanShot 2025-05-05 at 21 27 31@2x

See all features drawer

CleanShot 2025-05-05 at 21 27 44@2x

Pricing Table

CleanShot 2025-05-05 at 21 28 25@2x

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

vercel bot commented May 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 1:29am

Copy link

changeset-bot bot commented May 5, 2025

🦋 Changeset detected

Latest commit: 9ea3961

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/types Patch
@clerk/clerk-react Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/agent-toolkit Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/elements Patch
@clerk/expo-passkeys Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/remix Patch
@clerk/shared Patch
@clerk/tanstack-react-start Patch
@clerk/testing Patch
@clerk/themes Patch
@clerk/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@octoper octoper changed the title fix(clerk-js): Use billing permissions in Organization profile fix(clerk-js): Allow member with permission to manage billing in OP May 5, 2025
@octoper octoper self-assigned this May 5, 2025
@octoper octoper changed the title fix(clerk-js): Allow member with permission to manage billing in OP fix(clerk-js): Allow only members with manage billing permission to manage billing in OP May 5, 2025
@octoper octoper force-pushed the vaggelis/org-permissions-billing-section branch from 5092115 to d113913 Compare May 5, 2025 17:47
@octoper octoper marked this pull request as ready for review May 5, 2025 18:30
variant='info'
colorScheme='info'
title={localizationKeys(
'organizationProfile.__experimental_billingPage.alerts.noPemissionsToManageBilling',
Copy link
Member

@alexcarpenter alexcarpenter May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we still be including the __experimental_ prefixes still?

Copy link
Member

@alexcarpenter alexcarpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about disabling the buttons in PricingTable without any info as to why.

Screenshot 2025-05-05 at 2 40 23 PM

@octoper octoper force-pushed the vaggelis/org-permissions-billing-section branch from 938e520 to fbfd56c Compare May 5, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants