Skip to content

chore(clerk-js,localizations): align en-US strings for danger zone with other translations #5800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joschi
Copy link

@joschi joschi commented May 2, 2025

Description

The action description for organizationProfile.profilePage.dangerSection.deleteOrganization, organizationProfile.profilePage.dangerSection.leaveOrganization, and userProfile.deletePage wasn't aligned with any other translation which put the organization name or the phrase to type into the confirmation field in double quotes.

Examples from en-GB and the existing en-US localizations:

deleteOrganization: {
actionDescription: 'Type "{{organizationName}}" below to continue.',
messageLine1: 'Are you sure you want to delete this organisation?',
messageLine2: 'This action is permanent and irreversible.',
successMessage: 'You have deleted the organisation.',
title: 'Delete organisation',
},
leaveOrganization: {
actionDescription: 'Type "{{organizationName}}" below to continue.',
messageLine1:
'Are you sure you want to leave this organisation? You will lose access to this organisation and its applications.',
messageLine2: 'This action is permanent and irreversible.',
successMessage: 'You have left the organisation.',
title: 'Leave organisation',
},
deletePage: {
actionDescription: 'Type "Delete account" below to continue.',
confirm: 'Delete account',
messageLine1: 'Are you sure you want to delete your account?',
messageLine2: 'This action is permanent and irreversible.',
title: 'Delete account',
},

deleteOrganization: {
actionDescription: 'Type "{{organizationName}}" below to continue.',
messageLine1: 'Are you sure you want to delete this organization?',
messageLine2: 'This action is permanent and irreversible.',
successMessage: 'You have deleted the organization.',
title: 'Delete organization',
},
leaveOrganization: {
actionDescription: 'Type "{{organizationName}}" below to continue.',
messageLine1:
'Are you sure you want to leave this organization? You will lose access to this organization and its applications.',
messageLine2: 'This action is permanent and irreversible.',
successMessage: 'You have left the organization.',
title: 'Leave organization',
},
deletePage: {
actionDescription: 'Type "Delete account" below to continue.',
confirm: 'Delete account',
messageLine1: 'Are you sure you want to delete your account?',
messageLine2: 'This action is permanent and irreversible.',
title: 'Delete account',
},

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other: chore

Copy link

changeset-bot bot commented May 2, 2025

⚠️ No Changeset found

Latest commit: a483da5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 2, 2025

@joschi is attempting to deploy a commit to the Clerk Production Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants