Skip to content

fix(repo): Updating the timeout for nightly-checks job #5500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 1, 2025
Merged

fix(repo): Updating the timeout for nightly-checks job #5500

merged 5 commits into from
Apr 1, 2025

Conversation

jacekradko
Copy link
Member

@jacekradko jacekradko commented Apr 1, 2025 •
edited
Loading

Description

Extending the timeout for the nightly checks job. Also upgraded react to 19.1.0

Screenshot 2025-04-01 at 11 14 36 AM

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel Vercel
Copy link

vercel bot commented Apr 1, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2025 4:15pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1332ad2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jacekradko jacekradko changed the title fix(repo): Hardcode timeout for nightly-checks job fix(repo): Updating the timeout for nightly-checks job Apr 1, 2025
@jacekradko jacekradko merged commit a9fe718 into main Apr 1, 2025
32 checks passed
@jacekradko jacekradko deleted the fix/repo-nightly-checks branch April 1, 2025 16:25
tmilewski
tmilewski reviewed Apr 1, 2025
View reviewed changes
.github/workflows/nightly-checks.yml
Comment on lines +54 to +57
E2E_REACT_DOM_VERSION: '19.1.0'
E2E_REACT_VERSION: '19.1.0'
INTEGRATION_INSTANCE_KEYS: ${{ secrets.INTEGRATION_INSTANCE_KEYS }}
MAILSAC_API_KEY: ${{ secrets.MAILSAC_API_KEY }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacekradko 😄 My occasional and selective OCD thanks you.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmilewski My very omnipresent OCD says you are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmilewski tmilewski tmilewski left review comments

@brkalow brkalow brkalow approved these changes

@anagstef anagstef anagstef approved these changes

Assignees
No one assigned
Labels
actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jacekradko @tmilewski @brkalow @anagstef @clerk-cookie