Many changes #5
Open
Many changes #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Oct 15, 2015
ghost
commented
- Added a reference to scss-lint on syntax.
- Fixed a typo. (And probably introduced many others).
- Specified how to use spaces in HTML and CSS.
- Fixed a typo about using integers or decimals.
- Non-decorative images are always content.
- One should never embed images or anything in HTML. There are more drawbacks than benefits on it.
- Added a reference to scss-lint on syntax. - Fixed a typo. (And probably introduced many others). - Specified how to use spaces in HTML and CSS. - Fixed a typo about using integers or decimals. - Non-decorative images are always content. - One should never embed images or anything in HTML. There are more drawbacks than benefits on it.
| @@ -8,11 +8,11 @@ Always strive for specificity over brevity. The more specific our class selector | |||
|
|
|||
| ### Syntax | |||
|
|
|||
| We use the SCSS flavor of SASS to preprocess our CSS. | |||
| We use the SCSS flavor of SASS to preprocess our CSS. You might want to use [scss-lint](https://github.com/brigade/scss-lint) with the configuration provided in this repository. | |||
There was a problem hiding this comment.
@spicymagpie Depending on platform, https://github.com/sasstools/sass-lint is usually a better choice since it supports Sass & SCSS syntax and leverages LibSass which is signifcantly much faster accordingly.
Accordingly, it's often seen as a better choice, but there's nothing wrong with naming both—with it likely being the first one listed instead of this one or a Ruby Sass - LibSass distinction.
There was a problem hiding this comment.
Hey @lozandier, thanks for the suggestion! Frankly, I don't even know if this PR is still valid for what has been done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.