Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LMS151: add support for 25Hz/0.5° and 25Hz/0.25° #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

LMS151: add support for 25Hz/0.5° and 25Hz/0.25° #39

wants to merge 1 commit into from

Conversation

stephane-witzmann
Copy link

This patch fixes two things that were not working properly on the LMS151:

  • enable support for 25Hz scanning (only 50Hz was working)
  • fix where we get the angular resolution (-> enable support for 25Hz/0.25° mode). The field scanOutputRange.angularResolution looks incorrect (set at 5000 by the telemeter even in 0.25° mode). The one from scanCfg seems correct, so we use this one instead.

LMS151: add support for 25Hz/0.5° and 25Hz/0.25° (on top of 50Hz/0.5°…
b93f0ba 
…, which was the only one that worked before this patch).
@Entropy512
Copy link

I can confirm that the angular resolution in scanOutputRange is bogus on my LMS100 also. This patch is nearly identical to what I have running locally - although I didn't realize until earlier this week I still had a bogus time increment value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephane-witzmann @Entropy512