add github action to build and deploy the dev CD/service #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elrayle
force-pushed
the
elr/gh-action-dev-deploy
branch
14 times, most recently
from
8baeaae to
75c167f
Compare
elrayle
force-pushed
the
elr/gh-action-dev-deploy
branch
from
31298b2 to
4334f74
Compare
qtomlinson
reviewed
Jan 30, 2024
The variables defined in the `env:` section allow this script to be used in other contexts with minimal modification, primarily modifying just the environment variables. _NOTE: SEMVER is a place holder. A version is note assigned for dev deploys, but will be used in production deploys._ Change the file used for building to Dockerfile. The DevDockerfile is for localhost deploy only for dev testing.
elrayle
force-pushed
the
elr/gh-action-dev-deploy
branch
from
4334f74 to
662c166
Compare
elrayle
force-pushed
the
elr/gh-action-dev-deploy
branch
from
0af3f1b to
6aac9c9
Compare
|
@qtomlinson Thanks for the review. I've updated the code in the last two commits to address your comments. |
elrayle
force-pushed
the
elr/gh-action-dev-deploy
branch
from
e4f6248 to
2b273f6
Compare
Removes the temporary trigger to deploy on the PR branch.
qtomlinson
approved these changes
Jan 31, 2024
|
I've been going back and forth on whether in production, there should be sha and semver tags or just semver tag. It doesn't have to be resolved for this PR, but I'd like to get opinions on this. Theoretically, if you have the semver, you can get the sha from the release tag in GitHub. If we choose to only have a single tag for both dev and prod, it simplifies the action. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a GitHub action to perform the deploy of service to the dev service app in Azure. To support debugging, it also adds the sha of the current deploy to the status endpoint.
NOTE: As part of this work, Azure auth credentials were created following this documentation.
Follow-on Work