Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: graph improvements #271

Merged
merged 5 commits into from
Dec 4, 2019
Merged

metrics: graph improvements #271

merged 5 commits into from
Dec 4, 2019

Commits on Nov 25, 2019

  1. metrics: collectd: move legends under graphs 

    Move the legends under the graphs to give more width, and thus
resolution, to the final pictures.
This works well for the collectd graphs as they are spread out
into sets of single column graphs per page.

Signed-off-by: Graham Whaley <[email protected]>
    Graham Whaley committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    bf3449d View commit details
    Browse the repository at this point in the history

  2. metrics: report: shrink page margins for more resolution 

    The pdf output by default has large page margins, which wastes a lot of
page space, and reduces our 'resolution'. Shrink the margins to a pretty
minimal 1cm to increase the graph resolution. The document itself then
does not look as 'pretty', but we can see more data visually.

Signed-off-by: Graham Whaley <[email protected]>
    Graham Whaley committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    306195f View commit details
    Browse the repository at this point in the history

  3. metrics: report: improve interface y axis divs 

    Most of the time we have 0 interface errors or drops, so we pin the y
scale to '1', so we don't hit 'infinity' errors. That left us with a
strange y-axis label anomoly - as the axis was automatically divided
into 5 labels, and we got for some reason the sequence '0,0,0,1,1'.
That just plain looked wrong and confusing.
Fix it by using `pretty_breaks()` for the error/drop y axis, whilst
maintaining the `comma` count for the pod count y axis.

Signed-off-by: Graham Whaley <[email protected]>
    Graham Whaley committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    36f007e View commit details
    Browse the repository at this point in the history

  4. metrics: tidy: move local assign inside loop 

    The bootdata assignments were outside the 'valid file' check loop,
which meant in the case there was a data directory which did not
contain a valid scaling file, we would fail the assignment (as the
`local_bootdata` would be empty).

Fix by moving the assignments into the loop, thus only assigning when
we know we have valid data.

Signed-off-by: Graham Whaley <[email protected]>
    Graham Whaley committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    7cde752 View commit details
    Browse the repository at this point in the history

  5. metrics: tidy: widen the graphs 

    Move the legends to the bottom (underneath) for the tidy scaling graphs
to make them wider on the page, and thus easier to read with more
resolution.

Signed-off-by: Graham Whaley <[email protected]>
    Graham Whaley committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    21953a7 View commit details
    Browse the repository at this point in the history