add base run functionality #253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulya-tkch
commented
Jul 1, 2024
ulya-tkch
commented
Jul 1, 2024
cleanlab_studio/studio/enrichment.py
Outdated
| if options.get("tlm_options") | ||
| else {}, | ||
| ) | ||
| epr = EnrichmentResult.from_dict(response) |
ulya-tkch
commented
Jul 2, 2024
cleanlab_studio/errors.py
Outdated
| @@ -131,6 +135,10 @@ def __str__(self) -> str: | |||
| return error_msg | |||
|
|
|||
|
|
|||
| class EnrichmentProjectHandledError(CleansetHandledError): | |||
There was a problem hiding this comment.
Don't subclass from CleansetHandledError
eytanhanig
approved these changes
Jul 5, 2024
Comment on lines
1
to
11
| from cleanlab_studio.errors import EnrichmentProjectError, EnrichmentProjectHandledError | ||
| from cleanlab_studio.internal.api import api | ||
| from cleanlab_studio.internal.util import log_internal_error | ||
|
|
||
|
|
||
| from tqdm import tqdm | ||
|
|
||
|
|
||
| import itertools | ||
| import time | ||
| import traceback |
There was a problem hiding this comment.
nit: It looks like isort didn't run on this file. Do you have pre-commit installed for this repo?
| constrain_outputs: Optional[List[str]] = None, | ||
| extraction_pattern: Optional[str] = None, | ||
| optimize_prompt: Optional[bool] = True, | ||
| quality_preset: Optional[TLMQualityPreset] = "medium", |
There was a problem hiding this comment.
Suggested change
| quality_preset: Optional[TLMQualityPreset] = "medium", | |
| quality_preset: TLMQualityPreset = "medium", |
There was a problem hiding this comment.
Why are we making quality_preset not optional here if it is optional in enrichment_preview() method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Python API code for the base run functionality as well as wait until cleanset ready options.