Feat/telemetry #111
Feat/telemetry #111
Conversation
cleanlab_studio/internal/api/api.py
Outdated
| _ = requests.post( | ||
| f"{cli_base_url}/telemetry", | ||
| data=traceback.format_exc(), | ||
| headers=_construct_headers(api_key), | ||
| ) |
There was a problem hiding this comment.
we don't want failed telemetry to ever result in an error visible to users, so let's make sure that this is wrapped in a try-except. one example I can think of is if the user is having network issues. their first request will error out, then they'll see a network error raised from a telemetry request. this would be a bit confusing to users -- best to avoid that
There was a problem hiding this comment.
ah thanks that's a good point.
Fixed this, and also added function name and args to be sent to backend
There was a problem hiding this comment.
if this looks good now, I'll add it to all the functions that make api calls to our backend
cleanlab_studio/internal/api/api.py
Outdated
| arg_list = [repr(arg) for arg in args] | ||
| arg_list.extend(f"{k}={v!r}" for k, v in kwargs.items()) | ||
| arg_str = ", ".join(arg_list) |
There was a problem hiding this comment.
consider that this is considerably more invasive than just sending the traceback. would recommend checking w Anish to see if this is what we want to do at the moment
decorator that wraps functions we want to track and sends stack trace to backend if error raised
backend pr: https://github.com/cleanlab/cleanlab-studio-backend/pull/544