Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exe suffix for pip on Windows #92

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Add exe suffix for pip on Windows #92

merged 1 commit into from
Nov 30, 2023

Conversation

chrzyki
Copy link
Member

@chrzyki chrzyki commented Nov 30, 2023

requirements.txt was empty on Windows platform due to the fact that pip could not be found. On Windows, the 'script' is not pip but rather pip.exe. See also lexibank/pylexibank#272 (comment).

@chrzyki
Copy link
Member Author

chrzyki commented Nov 30, 2023

Just noted that on Windows platforms you seem to get an additional \n in the requirements, i.e.:

appdirs==1.4.4

attrs==23.1.0

Babel==2.13.1

bs4==0.0.1

...

Not yet sure where that comes from but I can have a look. However, I'm not sure whether this issue is problematic enough to potentially introduce more platform-specific code.

@xrotwang xrotwang merged commit 9ff9fe9 into master Nov 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants