fix Makefile.common to pass -f properly #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes to
Makefile.commonmerged in #165 left out the-f $(MAKEFILE_LIST)on the$(MAKE)lines used tomake new, so specifying an alternative Makefile was not working. I hope this fixes the issue raised by @bolliger32 in #165.I notice there was also
MAKELEVEL=0in this command in the older version ofMakefile.commonthat is omitted in the new version, but I don't see how we ever use that. So I'm leaving it out, but maybe someone knows why it was there?