Reordered 3d Classic code #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need consistent repository paths, the |
|
Also, need to update to use the new parameters in |
|
Updated to use new clawdata.py in example's setrun.py and in claw3ez.f. Also switched to new dynamic allocation setup in claw3ez and driver.f, as discussed on claw-dev. |
|
I am adding classic as a subrepository to the clawpack-org repository first and then I will pull this in. |
|
Works for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reordered 3D Classic code, based as much as possible on 3D PyClaw reordered Fortran for commonality's sake. Adds dynamic allocation, removes maxmx etc. This pull request also includes a variable-coefficient acoustics example, which uses the solver from the Riemann repo and the updated data.py from my clawutil pull request. I've tested it against the equivalent Clawpack 4.3 problem, and the final output files are identical.