Upgrade to [email protected] to fix frozen error #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I run the tests with node v0.12.5, I get the following
Warning: Cannot define property:48, object is not extensible. Use
--force to continue.
I believe node changed how it handles Object.freeze(). I managed to
trace it back to the temporary dependency which has a new release to
fix the error.
clarkeadg
added a commit
that referenced
this pull request
Jul 17, 2015
Upgrade to [email protected] to fix frozen error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am submitting this as a PR since your fork doesn't have issues.
When I run the tests with node v0.12.5, I get the following
I believe node changed how it handles Object.freeze(). So I managed to trace it back to the temporary dependency which has a new release to fix the error.
Turns out someone else figured it out and submitted a fix chrisgladd#30. Since people use your fork for the bower fix, if you could merge @OlenDavis's PR that'd be awesome.
fixes chrisgladd#41