Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate taxonomies ES-GA; add missing author in .ana files; add min… #763

Merged
merged 4 commits into from
Sep 15, 2023

Conversation

adina-v
Copy link
Collaborator

@adina-v adina-v commented Sep 15, 2023

…ister roles (roleName) in listPerson file

Translate taxonomies ES-GA; add missing author in .ana files; add minister roles (roleName) in listPerson file

adina-v and others added 2 commits September 15, 2023 13:14
…ister roles (roleName) in listPerson file

Translate taxonomies ES-GA; add missing author in .ana files; add minister roles (roleName) in listPerson file
@matyaskopp
Copy link
Collaborator

@adina-v the listPerson is not wellformed xml, this element does not have end:
https://github.com/adina-v/ParlaMint/blob/1e6feee1879a0a35b9cae28deb7f867dd1ba4f16/Samples/ParlaMint-ES-GA/ParlaMint-ES-GA-listPerson.xml#L3326

@matyaskopp
Copy link
Collaborator

@adina-v

  • you have pushed taxonomies translations, which will be integrated automatically into the ParlaMint-ES-GA 3.1 release
  • but there are also changes in the following:
    • Samples/ParlaMint-ES-GA/ParlaMint-ES-GA.ana.xml
    • Samples/ParlaMint-ES-GA/ParlaMint-ES-GA-listPerson.xml

I guess the ParlaMint-ES-GA-listPerson.xml is the final version of listPerson, but ParlaMint-ES-GA.ana.xml is only a sample root file because it does not contain links (<xi:include ... />) to all component files.

Can you please share these two final files with us(@matyaskopp and @TomazErjavec ) - ideally, send two URLs requestable simply with the wget command, so we can easily download them.
Are these files the only ones(except taxonomies) you expect to be changed in the next release?

@matyaskopp matyaskopp merged commit e49dfb2 into clarin-eric:data Sep 15, 2023
3 checks passed
@adina-v
Copy link
Collaborator Author

adina-v commented Sep 15, 2023

Thanks @matyaskopp for the feedback!
We just added a missing team member in the .ana file and completed the roleName for ministers in the listPerson file. No other changes on our part for the next release.
Here is the link for you and @TomazErjavec to a .zip file containing the final version of the .ana and listPerson files, downloadable with
wget --no-check-certificate 'https://docs.google.com/uc?export=download&id=1jBWjpNKoLpJ53UJq2h7-oQsWMhLh7i9S' -O new-final-ES-GA.zip

@matyaskopp matyaskopp mentioned this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants