Skip to content

Improve various AWS detectors #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Improve various AWS detectors #579

wants to merge 12 commits into from

Conversation

@Tulux
Copy link
Contributor

@Tulux Tulux commented Jan 10, 2025 •
edited
Loading

Fix:

  • integration_aws-rds-common: remove transformation (similar to previous PR)
  • integration_aws-efs: remove transformation + move alarms to critical/major levels instead of lower levels only + enable all alarms
  • integration_aws-alb: enable all alarms
  • integration_aws_nlb: remove transformation

Feat:

  • integration_aws-alb: optionalize detectors
  • integration_aws-rds-common: optionalize detectors
  • integration_aws-efs: optionalize detectors + set some default thresholds
  • integration_aws-nlb: optionalize detectors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BzSpi BzSpi Awaiting requested review from BzSpi BzSpi is a code owner

@cvauvarin cvauvarin Awaiting requested review from cvauvarin cvauvarin is a code owner

@haedri haedri Awaiting requested review from haedri haedri is a code owner

@pdecat pdecat Awaiting requested review from pdecat

@Shr3ps Shr3ps Awaiting requested review from Shr3ps Shr3ps is a code owner

@tchernomax tchernomax Awaiting requested review from tchernomax tchernomax is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Tulux