Rework smart agent elasticsearch #542
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gati0
requested review from
BzSpi,
JMHAUTBOIS-Claranet,
Shr3ps,
cvauvarin,
haedri,
pdecat and
tchernomax
as code owners
BzSpi
requested changes
Jan 10, 2024
| @@ -0,0 +1,19 @@ | |||
| module: ElasticSearch | |||
| name: "cluster status" | |||
| aggregation: true | |||
There was a problem hiding this comment.
If you have multiple clusters, this will do the transformation on all clusters 😃
| module: ElasticSearch | ||
| name: "cluster status" | ||
| aggregation: true | ||
| transformation: ".mean(over='5m')" |
There was a problem hiding this comment.
Why do a mean on 5 minutes since thresholds are strict comparison and lasting is already set ?
| @@ -0,0 +1,21 @@ | |||
| module: ElasticSearch | |||
| name: "cluster initializing shards" | |||
| aggregation: true | |||
There was a problem hiding this comment.
If you have multiple clusters, this will do the transformation on all clusters 😃
| module: ElasticSearch | ||
| name: "cluster initializing shards" | ||
| aggregation: true | ||
| transformation: ".min(over='15m')" |
There was a problem hiding this comment.
Already managed by triggering rule
Poil
reviewed
Jan 22, 2024
|
|
||
| signals: | ||
| signal: | ||
| metric: elasticsearch.cluster.number-of-nodes |
There was a problem hiding this comment.
should use elasticsearch.process.cpu.percent because current metric is not present if clusterHealthStatsMasterOnly: true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration of all elasticsearch detectors to generated mode with the gen_detectors module.