Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist settings between reloads #49

Open
wants to merge 5 commits into
base: gh-pages
Choose a base branch
from

Conversation

odegroot
Copy link
Contributor

@odegroot odegroot commented Jul 8, 2017

Before, each time I returned to the Factorio Calc, I had to re-enter all of my settings.

Now, when I return to the Factorio Calc, I can continue where I left off.

Demo: https://odegroot.github.io/factorio-calc/

Note

I also reformatted a file, for improved readability. This makes it look like I gave it a complete overhaul, when in fact nothing changed.
To view a diff with all of these whitespace changes hidden, add ?w=1 to the URL.
https://github.com/rubyruy/factorio-calc/pull/49/files?w=1

See also

#16 Preserve search state and form settings in URL so it can be shared
This PR does preserve settings, but not in the URL so it does not enable sending a link to someone, so this PR does not resolve that issue.

odegroot added 5 commits July 8, 2017 14:47
    Warning: Accessing factories like React.DOM.noscript has been deprecated and will be removed in v16.0+. Use the react-dom-factories package instead.  Version 1.0 provides a drop-in replacement. For more info, see https://fb.me/react-dom-factories
    printWarning @ react.js:2277
    lowPriorityWarning @ react.js:2296
    3.Object.keys.forEach.React.DOM.(anonymous function) @ react.js:298
    Modal_render @ react-modal.js:203

reactjs/react-modal#411
@abrindam
Copy link
Contributor

abrindam commented Jul 9, 2017

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants